View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0000082 | easycwmp | Enhancement | public | 2015-09-10 10:19 | 2015-09-26 12:12 |
| Reporter | feckert | Assigned To | mohamed.kallel | ||
| Priority | urgent | Severity | feature | Reproducibility | N/A |
| Status | resolved | Resolution | no change required | ||
| Summary | 0000082: Username and Password send during file download | ||||
| Description | Hello, I am using the genieacs as acs. I have set up auth for download files from the acs. But the acs does not send any password and username in it soap message. I saw in the source code that easycwmp extract this information for donwloading request from the soap message. I dont know if this is the default standard as written in the tr069 specification. I made an enhancement to use username and passowrd from acs.config section to send this password and username if the soap message does not have any values. I have also tested it and it works. I have added a patch. Kind regards Flo | ||||
| Tags | No tags attached. | ||||
| e-mail notification | |||||
|
|
system_easycwmp_patches_004-TDT-add-username-password-on-file-download.patch (925 bytes)
Index: easycwmp-1.1.6/src/xml.c
===================================================================
--- easycwmp-1.1.6.orig/src/xml.c
+++ easycwmp-1.1.6/src/xml.c
@@ -1316,7 +1316,12 @@ static int xml_handle_download(mxml_node
if (b && b->type == MXML_ELEMENT &&
!strcmp(b->value.element.name, "Username") &&
!b->child) {
- username = "";
+ if (config->acs->username != NULL) {
+ username = config->acs->username;
+ }
+ else {
+ username = "";
+ }
}
if (b && b->type == MXML_TEXT &&
b->value.text.string &&
@@ -1327,7 +1332,12 @@ static int xml_handle_download(mxml_node
if (b && b->type == MXML_ELEMENT &&
!strcmp(b->value.element.name, "Password") &&
!b->child) {
- password = "";
+ if (config->acs->password != NULL) {
+ password = config->acs->password;
+ }
+ else {
+ password = "";
+ }
}
if (b && b->type == MXML_TEXT &&
b->value.text.string &&
|
|
|
This out of the standard. I can not merge it. According to the standard, If you want to us authentication in the download then the ACS should send credentials in the Download message to the CPE |
|
|
OK we could close this issue :-( |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2015-09-10 10:19 | feckert | New Issue | |
| 2015-09-10 10:19 | feckert | File Added: system_easycwmp_patches_004-TDT-add-username-password-on-file-download.patch | |
| 2015-09-21 22:37 | mohamed.kallel | Note Added: 0000278 | |
| 2015-09-24 09:49 | feckert | Note Added: 0000280 | |
| 2015-09-26 12:12 | mohamed.kallel | Status | new => resolved |
| 2015-09-26 12:12 | mohamed.kallel | Resolution | open => no change required |
| 2015-09-26 12:12 | mohamed.kallel | Assigned To | => mohamed.kallel |
