EasyCwmp

View Issue Details Jump to Notes ] Issue History ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0000302easycwmp[All Projects] Bugpublic2017-10-18 18:102018-06-25 18:42
Reporterhmh 
Assigned Toemna.trigui@pivasoftware.com 
PrioritynormalSeverityminorReproducibilityalways
StatusresolvedResolutionfixed 
PlatformOSOpenWRTOS VersionChaos_Calmer
Summary0000302: Does not filter illegal characters in DEVICE_PRODUCT, interacts badly with some ACSes
DescriptionEasycwmp does not filter characters like "/" in DEVICE_PRODUCT (which are common in several router model names in OpenWRT/LEDE).

With FreeACS, this results in major issues when attempting to provision new firmware to the units, because the file path will have an extra "/" in it (which is not a path separator), and therefore the firmware data file cannot be found, ever.
Steps To ReproduceProvision a TP-Link TL-WDR842ND with OpenWRT, and attempt to update its firmware using FreeACS.

This results in an attempt to download an illegal file name that has an "/" in it, because the contents of /etc/device_info are:

DEVICE_MANUFACTURER='TP-LINK'
DEVICE_PRODUCT='SIMETBOX-TP-LINKTL-WR842N/NDv2'
DEVICE_REVISION='v0'

And this results in an illegal URI due to the forward slash in "WR842N/NDv2".
Additional InformationChanging the init.d/easycwmp script with the attached patch fixes the issue, although I am not sure this is the best way to do it. If anything, it illustrates what the issue is better than my description of it...
TagsNo tags attached.
Attached Filespatch file icon easycwmp_init.d_badchars.patch [^] (1,916 bytes) 2017-10-18 18:10 [Show Content]

- Relationships

-  Notes
(0000882)
emna.trigui@pivasoftware.com (developer)
2018-06-25 18:42

Delivered in EasyCwmp-1.7.0

- Issue History
Date Modified Username Field Change
2017-10-18 18:10 hmh New Issue
2017-10-18 18:10 hmh File Added: easycwmp_init.d_badchars.patch
2018-06-25 18:42 emna.trigui@pivasoftware.com Note Added: 0000882
2018-06-25 18:42 emna.trigui@pivasoftware.com Status new => resolved
2018-06-25 18:42 emna.trigui@pivasoftware.com Resolution open => fixed
2018-06-25 18:42 emna.trigui@pivasoftware.com Assigned To => emna.trigui@pivasoftware.com


Copyright © 2000 - 2018 MantisBT Team
Powered by Mantis Bugtracker